fix: fix from field in eth receipt rpc method

[skosito]

Description

ethermint PR: zeta-chain/ethermint#206

How Has This Been Tested?

• Tested CCTX in localnet
• Tested in development environment
• Go unit tests
• Go integration tests
• Tested via GitHub Actions

Summary by CodeRabbit

• Chores

  • Updated a key dependency to a newer version, offering improved stability and access to the latest enhancements.

• Bug Fixes

  • Enhanced error handling during transaction processing to ensure a more robust and reliable experience.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

This pull request updates the dependency version for github.com/zeta-chain/ethermint in the go.mod file and refines error handling in two backend methods (GetTransactionReceipt and getAccountNonce). Both methods now retrieve the sender address using GetSender(b.chainID) with added error checking and debug logging.

Changes

Files	Change Summary
go.mod	Updated github.com/zeta-chain/ethermint version from v0.0.0-20250124145234-b12523a2c64f to v0.0.0-20250210141109-c8cb0fa0d95d.
rpc/backend/tx_info.go, rpc/backend/utils.go	Modified retrieval of the sender address: replaced GetSender() with GetSender(b.chainID) and added error handling with debug logging in the GetTransactionReceipt and getAccountNonce methods.

Sequence Diagram(s)

sequenceDiagram
    participant B as Backend
    participant E as EthMsg
    participant L as Logger

    B->>E: Call GetSender(b.chainID)
    alt Successful Retrieval
        E-->>B: Return sender address
    else Error Occurs
        E-->>B: Return error
        B->>L: Log debug error message
    end

Loading

Possibly related PRs

• chore: bump ethermint #2854: Also updates the github.com/zeta-chain/ethermint dependency in the go.mod file, reflecting a similar dependency version modification.

Suggested labels

no-changelog, UPGRADE_TESTS

Suggested reviewers

• gartnera
• lumtis
• fbac
• kingpinXD

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[CryptoFewka]

Shouldn't this have some kind of a change log entry?

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

rpc/backend/tx_info.go (1)

240-243: Consider adding a defensive nil check for chainID.

While the current implementation is correct, adding a nil check for chainID would make the code more robust against potential configuration issues.

-		from, err = ethMsg.GetSender(b.chainID)
+		if b.chainID == nil {
+			return nil, errors.New("chainID is nil")
+		}
+		from, err = ethMsg.GetSender(b.chainID)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 97c82cc and 67f823b.

⛔ Files ignored due to path filters (1)

• go.sum is excluded by !**/*.sum

📒 Files selected for processing (3)

• go.mod (1 hunks)
• rpc/backend/tx_info.go (1 hunks)
• rpc/backend/utils.go (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• go.mod

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.go`: Review the Go code, point out issues relative to ...

**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.

• rpc/backend/utils.go
• rpc/backend/tx_info.go

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: start-e2e-test / e2e

🔇 Additional comments (2)

rpc/backend/utils.go (1)

110-113: LGTM! Improved error handling for sender parsing.

The addition of chainID parameter and error logging enhances debugging capabilities while maintaining graceful error handling.

rpc/backend/tx_info.go (1)

240-243: LGTM! Consistent error handling pattern.

The error handling and debug logging implementation aligns well with the changes in utils.go, providing a consistent approach across the codebase.