fix: skip block scanning actions on Arbitrum and Avalanch networks (v27) by CryptoFewka · Pull Request #3554 · zeta-chain/node

CryptoFewka · 2025-02-19T16:55:34Z

Description

This PR takes a hatchet to zetaclient/chains/evm/observer/inbound.go to validate the expected gains from not observing TSS direct transfers on Arbitrum and Avalanche.

How Has This Been Tested?

coderabbitai · 2025-02-19T16:55:43Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

CryptoFewka · 2025-02-19T16:58:02Z

zetaclient/chains/evm/observer/inbound.go

+
+	// Initialize lastScannedTssRecvd to a known "unset" value
+	var lastScannedTssRecvd uint64 = 0 // Assuming 0 is an appropriate "unset" value
+	if ob.Chain().ChainId != 421614 && ob.Chain().ChainId != 42161 && ob.Chain().ChainId != 43113 && ob.Chain().ChainId != 43114  {


@morde08 There has to be a better way to write line 152, right?

Reverse the check with Ethereum chain IDs

chainID := ob.Chain().ChainId if chainID == 1 || chainID == 11155111 || chainID == 1337

This will be a far larger check once we pull in BSC and Polygon where direct TSS deposits are still supported presumably, right?

Let's define a slice containing all chain ids and use https://pkg.go.dev/slices#Contains

codecov · 2025-02-19T18:27:35Z

Codecov Report

Attention: Patch coverage is 0% with 90 lines in your changes missing coverage. Please review.

Project coverage is 64.30%. Comparing base (caa4804) to head (67ac94c).
Report is 1 commits behind head on release/v27.

Files with missing lines	Patch %	Lines
zetaclient/chains/evm/observer/inbound.go	0.00%	90 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           release/v27    #3554      +/-   ##
===============================================
- Coverage        64.42%   64.30%   -0.12%     
===============================================
  Files              436      436              
  Lines            30380    30435      +55     
===============================================
  Hits             19571    19571              
- Misses            9968    10023      +55     
  Partials           841      841

Files with missing lines	Coverage Δ
zetaclient/chains/evm/observer/inbound.go	`36.06% <0.00%> (-3.58%)`	⬇️

Hotfix to not observe TSS Addr direct TX.

d2b214e

Remove whitespace

ffe8fd9

CryptoFewka commented Feb 19, 2025

View reviewed changes

CryptoFewka changed the title ~~Hotfix to not observe TSS Addr direct TX.~~ fix: Hotfix to not observe TSS Addr direct TX in v27 zetaclient Feb 19, 2025

CryptoFewka added 6 commits February 19, 2025 11:43

invert logic to only include EVM chains currently deployed

e2176dc

add polygon to direct TSS support for now

3d4f633

add fix for declared but not used

8c0f978

revert logger change

ec7e155

add item to changelog.md

8255212

bugfix: fix typo in function name called

9efc91c

CryptoFewka and others added 8 commits February 19, 2025 12:55

lint fixes

757871b

lint fixes

512a683

skip setting lastScannedTssRecvd to 0

eb11aeb

do scanning in parallel

fd70eec

skip FilterTSSOutbound for ARB and AVAX as it time-consuming

107e809

execute FilterTSSOutbound only when shouldScanTSSRecieve is true

4a34a15

remove cruft comment

a381318

cleanup naming and comments

67ac94c

gartnera changed the title ~~fix: Hotfix to not observe TSS Addr direct TX in v27 zetaclient~~ fix: skip block scanning actions on Arbitrum and Avalanch networks Feb 19, 2025

gartnera changed the title ~~fix: skip block scanning actions on Arbitrum and Avalanch networks~~ fix: skip block scanning actions on Arbitrum and Avalanch networks (v27) Feb 19, 2025

gartnera approved these changes Feb 19, 2025

View reviewed changes

gartnera marked this pull request as ready for review February 19, 2025 22:12

gartnera requested a review from a team as a code owner February 19, 2025 22:12

ws4charlie approved these changes Feb 19, 2025

View reviewed changes

CryptoFewka merged commit c6f75bb into release/v27 Feb 19, 2025
46 of 47 checks passed

CryptoFewka deleted the cryptofewka/v27-arbitrum-observation-hotfix branch February 19, 2025 22:29

gartnera mentioned this pull request Feb 20, 2025

Athens: ZetaClient has difficulty keeping up with observing Arbitrum Sepolia #3549

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: skip block scanning actions on Arbitrum and Avalanch networks (v27)#3554

fix: skip block scanning actions on Arbitrum and Avalanch networks (v27)#3554
CryptoFewka merged 16 commits intorelease/v27from
cryptofewka/v27-arbitrum-observation-hotfix

CryptoFewka commented Feb 19, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 19, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

CryptoFewka Feb 19, 2025

Uh oh!

lumtis Feb 19, 2025 •

edited

Loading

Uh oh!

CryptoFewka Feb 19, 2025

Uh oh!

lumtis Feb 19, 2025

Uh oh!

codecov bot commented Feb 19, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

CryptoFewka commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Uh oh!

coderabbitai bot commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

CryptoFewka Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

lumtis Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CryptoFewka Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

lumtis Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CryptoFewka commented Feb 19, 2025 •

edited

Loading

coderabbitai bot commented Feb 19, 2025 •

edited

Loading

lumtis Feb 19, 2025 •

edited

Loading

codecov bot commented Feb 19, 2025 •

edited

Loading