test: improve check for EnsureNoStaleBallots to ignore Pending Ballots#3627
test: improve check for EnsureNoStaleBallots to ignore Pending Ballots#3627
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe change modifies the logic in the Changes
Sequence Diagram(s)sequenceDiagram
participant Runner as E2ERunner
participant BallotList as Ballots
Runner->>BallotList: Retrieve ballotsRes.Ballots
loop For each ballot in BallotList
BallotList->>BallotList: Check IsFinalized()
alt Ballot is finalized
Note right of Runner: Update firstBallotCreationHeight
end
end
Runner->>Runner: Compare firstBallotCreationHeight with staleBlockStart
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
e2e/runner/require.go(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.go`: Review the Go code, point out issues relative to ...
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.
e2e/runner/require.go
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: start-upgrade-test / e2e
- GitHub Check: start-e2e-test / e2e
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
e2e/runner/require.go (1)
65-65: Update function comment to reflect new behaviorThe function comment should be updated to clearly indicate that it now only checks for stale finalized ballots, ignoring pending ones.
-// EnsureNoStaleBallots ensures that there are no stale ballots left on the chain. +// EnsureNoStaleBallots ensures that there are no stale finalized ballots left on the chain. +// Pending ballots are ignored as they are not considered stale.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
e2e/runner/require.go(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.go`: Review the Go code, point out issues relative to ...
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.
e2e/runner/require.go
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: start-upgrade-test / e2e
- GitHub Check: start-e2e-test / e2e
3 participants
Description
After this PR
#3553 - pending ballots are not deleted at the maturity blocks of
100.However for e2e tests all ballots should be finalized , but for runs some garbage ballots get created which are triggereing this issue intermitently
closes : #3626
How Has This Been Tested?
Summary by CodeRabbit