Skip to content

fix: upgrade cosmos sdk to v0.50.13#3702

Merged
gartnera merged 1 commit intodevelopfrom
sdk-0-50-13
Mar 12, 2025
Merged

fix: upgrade cosmos sdk to v0.50.13#3702
gartnera merged 1 commit intodevelopfrom
sdk-0-50-13

Conversation

@gartnera
Copy link
Contributor

@gartnera gartnera commented Mar 12, 2025

https://github.com/cosmos/cosmos-sdk/releases/tag/v0.50.13

This will most likely be backported to v28 and v29 so no changelog is needed

Summary by CodeRabbit

  • Chores
    • Updated core dependency libraries to their latest stable versions.
    • Streamlined dependency management to enhance overall stability and maintainability.

@gartnera gartnera added the no-changelog Skip changelog CI check label Mar 12, 2025
@gartnera gartnera requested a review from a team as a code owner March 12, 2025 16:53
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 12, 2025

📝 Walkthrough

Walkthrough

This pull request updates the dependency declarations in the go.mod file. It upgrades the github.com/cosmos/cosmos-sdk version from v0.50.12 to v0.50.13, changes certain dependencies from indirect to direct (github.com/fsnotify/fsnotify and github.com/mr-tron/base58), and adds a new direct dependency (github.com/hashicorp/golang-lru/v2 at v2.0.7).

Changes

File Change Summary
go.mod - Cosmos SDK: Updated from v0.50.12 to v0.50.13
- fsnotify: Changed from an indirect to direct dependency (v1.7.0)
- golang-lru/v2: Added as a new direct dependency (v2.0.7)
- base58: Converted from an indirect to direct dependency (v1.2.0)

Possibly related PRs

Suggested labels

UPGRADE_TESTS

Suggested reviewers

  • lumtis
  • kingpinXD
  • swift1337

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5bac6f9 and 91dd86d.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod (4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: start-e2e-test / e2e
🔇 Additional comments (4)
go.mod (4)

18-18: Cosmos SDK Version Upgrade:
The dependency github.com/cosmos/cosmos-sdk has been updated to v0.50.13. Please verify that all modules interfacing with Cosmos SDK are compatible with this version and that any upstream breaking changes have been addressed.


134-134: Direct Inclusion of fsnotify:
The change promotes github.com/fsnotify/fsnotify v1.7.0 from an indirect to a direct dependency. Confirm that the code explicitly relies on fsnotify so that the direct dependency is justified, and verify that no conflicts arise with transitive dependencies.


221-221: Direct Dependency for Base58 Library:
The dependency for github.com/mr-tron/base58 is now direct rather than indirect. Please ensure that this change reflects intentional usage in your codebase and that its exposure as a direct dependency does not inadvertently pull in unwanted behavior.


311-311: Addition of Hashicorp Golang LRU Dependency:
A new direct dependency github.com/hashicorp/golang-lru/v2 v2.0.7 has been added. Verify that this dependency is necessary for your implementation and that its integration will not introduce version conflicts with other LRU implementations in use.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gartnera gartnera enabled auto-merge March 12, 2025 16:53
@gartnera gartnera added this pull request to the merge queue Mar 12, 2025
auto-merge was automatically disabled March 12, 2025 17:30

Pull Request is not mergeable

Merged via the queue into develop with commit e46b518 Mar 12, 2025
48 checks passed
@gartnera gartnera deleted the sdk-0-50-13 branch March 12, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Skip changelog CI check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants