fix: revert Bitcoin inbound if there no memo provided by user#3752
Merged
morde08 merged 2 commits intorelease/v29from Mar 24, 2025
Merged
fix: revert Bitcoin inbound if there no memo provided by user#3752morde08 merged 2 commits intorelease/v29from
morde08 merged 2 commits intorelease/v29from
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v29 #3752 +/- ##
===============================================
- Coverage 64.44% 64.43% -0.01%
===============================================
Files 469 469
Lines 32891 32899 +8
===============================================
+ Hits 21195 21199 +4
- Misses 10727 10731 +4
Partials 969 969
🚀 New features to boost your workflow:
|
lumtis
approved these changes
Mar 24, 2025
skosito
approved these changes
Mar 24, 2025
lumtis
reviewed
Mar 24, 2025
| // make a deposit without memo | ||
| utxos := r.ListDeployerUTXOs() | ||
| txHash, err := r.SendToTSSFromDeployerWithMemo(0.1, utxos[:1], []byte{}) | ||
| txHash, err := r.SendToTSSFromDeployerWithMemo(0.1, utxos[:1], nil) |
Contributor
There was a problem hiding this comment.
Just a note for the develop PR: Let's cover for non existant and empty memo
Contributor
Author
There was a problem hiding this comment.
Yeah. Both non existant and empty memo are covered in here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The v29 is able to revert Bitcoin deposits that carry incorrectly formatted memo (e.g., invalid receiver address), but it cannot properly revert deposits that carry no memo at all, which are supposed be reverted.
This fix will allow no-memo deposits to be able to go through ZetaChain and get funds reverted.
How Has This Been Tested?