refactor: set zeta protocol fee to zero

[lumtis]

Description

• Set ZETA additional protocol fee to zero as this fee is no longer relevant
• Fix a invalid check for ZETA withdraw to the bitcoin chain

Summary by CodeRabbit

• Refactor
  • Protocol fee for ZETA transactions has been set to zero. This change is reflected in the system and will affect any operations or queries involving the protocol fee.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

This change removes the hardcoded protocol fee constant from the crosschain module and updates the GetProtocolFee() function to always return zero. The function is retained for backward compatibility but no longer provides a non-zero fee. Additionally, the changelog is updated under the "Refactor" section to document this protocol fee adjustment for the unreleased version.

Changes

File(s)	Change Summary
x/crosschain/types/keys.go	Removed the ProtocolFee constant; updated GetProtocolFee() to return zero instead of a fixed value.
changelog.md	Added a changelog entry under "Refactor" for the protocol fee change in PR #3813.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant CrosschainTypes

    Client->>CrosschainTypes: Call GetProtocolFee()
    CrosschainTypes-->>Client: Return ZeroUint

Loading

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.26%. Comparing base (a32ffd8) to head (62240d1).
Report is 3 commits behind head on develop.

Files with missing lines	Patch %	Lines
x/crosschain/keeper/evm_hooks.go	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3813   +/-   ##
========================================
  Coverage    64.26%   64.26%           
========================================
  Files          463      463           
  Lines        33248    33249    +1     
========================================
+ Hits         21368    21369    +1     
  Misses       10898    10898           
  Partials       982      982           

Files with missing lines	Coverage Δ
x/crosschain/keeper/evm_hooks.go	83.39% <50.00%> (+0.06%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ws4charlie]

looks good