fix: show correct gas limit for synthetic txs#3920
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe changes introduce a new mechanism for capturing and propagating the gas limit of synthetic Ethereum transactions throughout the codebase. This includes updating event emission to include the gas limit, extending data structures to store and forward this value, and ensuring that the correct gas limit is displayed in RPC responses. The dependency on Changes
Sequence Diagram(s)sequenceDiagram
participant EVM as EVM Module
participant Keeper as Fungible Keeper
participant Event as Event System
participant RPC as RPC Layer
participant Client as Client
Client->>RPC: Request synthetic transaction details
RPC->>Event: Query for transaction events
Event->>Keeper: Retrieve event attributes (includes GasLimit)
Keeper->>Event: Emit event with GasLimit attribute
Event->>RPC: Return attributes (GasLimit included)
RPC->>Client: Respond with transaction info (correct GasLimit)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3920 +/- ##
========================================
Coverage 64.94% 64.94%
========================================
Files 470 470
Lines 34386 34391 +5
========================================
+ Hits 22331 22336 +5
Misses 11024 11024
Partials 1031 1031
🚀 New features to boost your workflow:
|
Description
How Has This Been Tested?
Summary by CodeRabbit
Bug Fixes
New Features
Documentation
Chores