Skip to content

fix: show correct gas limit for synthetic txs#3920

Merged
skosito merged 4 commits intodevelopfrom
correct-gas-limit-for-synthetic-txs
May 28, 2025
Merged

fix: show correct gas limit for synthetic txs#3920
skosito merged 4 commits intodevelopfrom
correct-gas-limit-for-synthetic-txs

Conversation

@skosito
Copy link
Member

@skosito skosito commented May 27, 2025

Description

How Has This Been Tested?

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Summary by CodeRabbit

  • Bug Fixes

    • Ensured the correct gas limit is displayed for synthetic transactions.
  • New Features

    • Added gas limit information to transaction details for improved visibility in synthetic and EVM-related transactions.
  • Documentation

    • Updated the changelog to reflect the latest fix.
  • Chores

    • Upgraded a dependency to a newer version for improved stability and compatibility.

@skosito skosito requested a review from a team as a code owner May 27, 2025 11:55
@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 27, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

The changes introduce a new mechanism for capturing and propagating the gas limit of synthetic Ethereum transactions throughout the codebase. This includes updating event emission to include the gas limit, extending data structures to store and forward this value, and ensuring that the correct gas limit is displayed in RPC responses. The dependency on ethermint is also updated.

Changes

File(s) Change Summary
changelog.md Added entry for PR #3920 documenting the fix for correct gas limit display in synthetic transactions.
go.mod Updated github.com/zeta-chain/ethermint dependency to a newer version.
rpc/types/events.go Added GasLimit field to ParsedTx; parses and propagates gas limit from event attributes.
rpc/types/types.go Added GasLimit field to TxResultAdditionalFields struct.
rpc/backend/blocks.go, rpc/types/utils.go Changed logic to use GasLimit instead of GasUsed when constructing synthetic/RPC transactions.
x/fungible/keeper/evm.go Emits the gas limit as an event attribute for synthetic transactions.

Sequence Diagram(s)

sequenceDiagram
    participant EVM as EVM Module
    participant Keeper as Fungible Keeper
    participant Event as Event System
    participant RPC as RPC Layer
    participant Client as Client

    Client->>RPC: Request synthetic transaction details
    RPC->>Event: Query for transaction events
    Event->>Keeper: Retrieve event attributes (includes GasLimit)
    Keeper->>Event: Emit event with GasLimit attribute
    Event->>RPC: Return attributes (GasLimit included)
    RPC->>Client: Respond with transaction info (correct GasLimit)
Loading

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@skosito skosito enabled auto-merge May 28, 2025 11:26
@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.94%. Comparing base (4641c74) to head (b8c908f).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3920   +/-   ##
========================================
  Coverage    64.94%   64.94%           
========================================
  Files          470      470           
  Lines        34386    34391    +5     
========================================
+ Hits         22331    22336    +5     
  Misses       11024    11024           
  Partials      1031     1031           
Files with missing lines Coverage Δ
x/fungible/keeper/evm.go 85.27% <100.00%> (+0.12%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@skosito skosito added this pull request to the merge queue May 28, 2025
Merged via the queue into develop with commit 194548f May 28, 2025
47 checks passed
@skosito skosito deleted the correct-gas-limit-for-synthetic-txs branch May 28, 2025 14:41
skosito added a commit that referenced this pull request Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants