Skip to content

fix: revert sui CCTX that contains invalid receiver address#3945

Merged
ws4charlie merged 3 commits intorelease/v31from
fix-sui-invalid-receiver-by-revert-cctx
Jun 4, 2025
Merged

fix: revert sui CCTX that contains invalid receiver address#3945
ws4charlie merged 3 commits intorelease/v31from
fix-sui-invalid-receiver-by-revert-cctx

Conversation

@ws4charlie
Copy link
Contributor

Description

This PR is to unblock any future CCTXs that contain invalid Sui receiver addresses.

Here is an example CCTX in the history: https://zetachain-testnet-api.itrocket.net/zeta-chain/crosschain/cctx/103/215

How Has This Been Tested?

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 2, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ws4charlie ws4charlie added chain:sui SUI_TESTS Run make start-sui-tests labels Jun 2, 2025
@github-actions github-actions bot added breaking:cli and removed chain:sui SUI_TESTS Run make start-sui-tests labels Jun 2, 2025
@ws4charlie ws4charlie added no-changelog Skip changelog CI check chain:sui SUI_TESTS Run make start-sui-tests labels Jun 2, 2025
@ws4charlie ws4charlie marked this pull request as ready for review June 2, 2025 21:37
@ws4charlie ws4charlie requested a review from a team as a code owner June 2, 2025 21:37
@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.88%. Comparing base (23cb8e4) to head (e5cdf92).
Report is 1 commits behind head on release/v31.

Files with missing lines Patch % Lines
zetaclient/chains/sui/signer/signer.go 88.46% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release/v31    #3945      +/-   ##
===============================================
+ Coverage        64.87%   64.88%   +0.01%     
===============================================
  Files              472      472              
  Lines            34442    34464      +22     
===============================================
+ Hits             22343    22362      +19     
- Misses           11071    11073       +2     
- Partials          1028     1029       +1     
Files with missing lines Coverage Δ
zetaclient/chains/sui/signer/signer.go 50.38% <88.46%> (+7.26%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@julianrubino julianrubino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validation lgtm

Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once merge, need to make same PR on develop

@ws4charlie ws4charlie merged commit 756c6bb into release/v31 Jun 4, 2025
46 checks passed
@ws4charlie ws4charlie deleted the fix-sui-invalid-receiver-by-revert-cctx branch June 4, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking:cli chain:sui no-changelog Skip changelog CI check SUI_TESTS Run make start-sui-tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants