This repository was archived by the owner on Nov 22, 2025. It is now read-only.
Expand target bit set, shrink file size, and add loongarch64-linux-gnusf#12
Merged
alexrp merged 7 commits intoziglang:mainfrom Oct 6, 2024
alexrp:main
Merged
Expand target bit set, shrink file size, and add loongarch64-linux-gnusf#12alexrp merged 7 commits intoziglang:mainfrom alexrp:main
loongarch64-linux-gnusf#12alexrp merged 7 commits intoziglang:mainfrom
alexrp:main
Conversation
Member
|
Nice work, clever solution! |
andrewrk
approved these changes
Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanding the target bit set from
u32tou64results in an unacceptable size increase. So instead, I changed it to be written as au64in ULEB128. Even after addingloongarch64-linux-gnusf, theabilistsfile shrunk from 269 KB to 265 KB. I also moved the inclusion terminal bit over to the library index byte since that value is expected to be very small ~forever, shrinking the file further to 242 KB (because that bit was kind of undermining ULEB128). Finally, I changed the object size to beu16written as ULEB128 too, resulting in a final size of 240 KB.Closes #11.