Unable to -Drelease-fast=true in MacBook Air M1

[kimmolinna]

Zig Version

0.11.0-dev.635+225ed65ed

Steps to Reproduce and Observed Behavior

1. Fetch duckdb-zig-build repo
2. Build with command zig build -Drelease-fast

I will get the following error message:

MachO Flush... thread 154182 panic: attempt to use null value
src/link/MachO/dead_strip.zig:61:66: 0x10301797f in collectRoots (zig)
src/link/MachO/dead_strip.zig:32:21: 0x102cd4333 in gcAtoms (zig)
src/link/MachO/zld.zig:4238:35: 0x102995853 in linkWithZld (zig)
src/link/MachO.zig:426:44: 0x102798b33 in flush (zig)
src/link.zig:796:72: 0x102591adf in flush (zig)
src/Compilation.zig:2516:24: 0x10259126b in flush (zig)
src/Compilation.zig:2497:23: 0x102594567 in update (zig)
src/main.zig:3423:20: 0x1025bfef7 in updateModule (zig)
src/main.zig:3085:17: 0x1024a553f in buildOutputType (zig)
src/main.zig:257:31: 0x10247ee07 in mainArgs (zig)
src/main.zig:199:20: 0x10247e48f in main (zig)
lib/std/start.zig:614:37: 0x1024807ef in main (zig)
???:?:?: 0x1ab3dfe4f in ??? (???)
???:?:?: 0x3f09ffffffffffff in ??? (???)
error: duckdb...

zig buildworks

Expected Behavior

I expected successful linking.

[kubkon]

For anyone wanting to repro this, openssl installed via Homebrew is required.

[kimmolinna]

@kubkon The other option is to comment/delete everything related to openssl and httpfs.

[kimmolinna]

This build.zig is withoutopenssland httpfs. Sorry! I should have done that immediately like this.

[kubkon]

That's fine. I managed to repro it just fine after I installed openssl on my M1Pro, so we're good! I am concerned there are no source lines pulled from DWARF in the stack trace you submitted however. This is unrelated but something that will need to be fixed.

[kimmolinna]

That's also my bad. I just cut the error message. The whole message is like:

linna@KimmoM1 duckdb-zig-build % zig build -Drelease-fast
        MachO Flush... thread 170542 panic: attempt to use null value
src/link/MachO/dead_strip.zig:61:66: 0x10188b97f in collectRoots (zig)
src/link/MachO/dead_strip.zig:32:21: 0x101548333 in gcAtoms (zig)
src/link/MachO/zld.zig:4238:35: 0x101209853 in linkWithZld (zig)
src/link/MachO.zig:426:44: 0x10100cb33 in flush (zig)
src/link.zig:796:72: 0x100e05adf in flush (zig)
src/Compilation.zig:2516:24: 0x100e0526b in flush (zig)
src/Compilation.zig:2497:23: 0x100e08567 in update (zig)
src/main.zig:3423:20: 0x100e33ef7 in updateModule (zig)
src/main.zig:3085:17: 0x100d1953f in buildOutputType (zig)
src/main.zig:257:31: 0x100cf2e07 in mainArgs (zig)
src/main.zig:199:20: 0x100cf248f in main (zig)
lib/std/start.zig:614:37: 0x100cf47ef in main (zig)
???:?:?: 0x1ab3dfe4f in ??? (???)
???:?:?: 0xbd25ffffffffffff in ??? (???)
error: duckdb...
error: The following command terminated unexpectedly:
/Users/linna/zig/build/stage3/bin/zig build-lib @/Users/linna/duckdb-zig-build/zig-cache/args/a6ee7ce3db25769821abfb8df618bbe44a6282c315fc416d138c6872878209ca 
error: the following build command failed with exit code 6:
/Users/linna/duckdb-zig-build/zig-cache/o/a63a609e0321fd8a03c7374e171c6eda/build /Users/linna/zig/build/stage3/bin/zig /Users/linna/duckdb-zig-build /Users/linna/duckdb-zig-build/zig-cache /Users/linna/.cache/zig -Drelease-fast

[kubkon]

It's not your fault and that's not what I meant. I expected a stack trace looking like this:

❯ ../zig/build/stage3/bin/zig build -Drelease-fast
MachO Flush... thread 9256189 panic: attempt to use null value
/Users/kubkon/dev/zig/src/link/MachO/dead_strip.zig:61:66: 0x105877acf in collectRoots (zig)
                const object = zld.objects.items[global.getFile().?];
                                                                 ^
/Users/kubkon/dev/zig/src/link/MachO/dead_strip.zig:32:21: 0x105534483 in gcAtoms (zig)
    try collectRoots(zld, &roots);
                    ^
/Users/kubkon/dev/zig/src/link/MachO/zld.zig:4238:35: 0x1051f5b67 in linkWithZld (zig)
            try dead_strip.gcAtoms(&zld, reverse_lookups);
                                  ^
/Users/kubkon/dev/zig/src/link/MachO.zig:426:44: 0x104ff8e47 in flush (zig)
        .one_shot => return zld.linkWithZld(self, comp, prog_node),
                                           ^
/Users/kubkon/dev/zig/src/link.zig:796:72: 0x104df19df in flush (zig)
            .macho => return @fieldParentPtr(MachO, "base", base).flush(comp, prog_node),
                                                                       ^
/Users/kubkon/dev/zig/src/Compilation.zig:2516:24: 0x104df116b in flush (zig)
    comp.bin_file.flush(comp, prog_node) catch |err| switch (err) {
                       ^
/Users/kubkon/dev/zig/src/Compilation.zig:2497:23: 0x104df4467 in update (zig)
        try comp.flush(main_progress_node);
                      ^
/Users/kubkon/dev/zig/src/main.zig:3423:20: 0x104e1fdf7 in updateModule (zig)
    try comp.update();
                   ^
/Users/kubkon/dev/zig/src/main.zig:3085:17: 0x104d0543f in buildOutputType (zig)
    updateModule(gpa, comp, hook) catch |err| switch (err) {
                ^
/Users/kubkon/dev/zig/src/main.zig:257:31: 0x104cded07 in mainArgs (zig)
        return buildOutputType(gpa, arena, args, .{ .build = .Lib });
                              ^
/Users/kubkon/dev/zig/src/main.zig:199:20: 0x104cde38f in main (zig)
    return mainArgs(gpa, arena, args);
                   ^
/Users/kubkon/dev/zig/lib/std/start.zig:614:37: 0x104ce06ef in main (zig)
            const result = root.main() catch |err| {
                                    ^
???:?:?: 0x1ac94be4f in ??? (???)
???:?:?: 0x285e7fffffffffff in ??? (???)
error: duckdb...

This is with my tweak to the compiler forcing absolute paths in DWARF tho. Note the source lines printed under each address in each call frame.

[Jarred-Sumner]

@kubkon I run into an issue with a similar stacktrace when trying to build Zig from source on macOS using zig build

When using cmake via brew install zig --head though it works

I suspect the issue is related to what version of clang / llvm is linked

[kubkon]

@kubkon I run into an issue with a similar stacktrace when trying to build Zig from source on macOS using zig build

When using cmake via brew install zig --head though it works

I suspect the issue is related to what version of clang / llvm is linked

It's actually an issue with having relative source file paths in DWARF. stage1 used to always specify absolute paths while in stage2 we took a different approach where we allow for some paths to be relative instead of force resolve them to absolute. While a nice idea in principle, it seems to be too delicate so we will probably fallback to stage1 behavior for this.