std.math.big.int: breaking API changes to prevent UAF#11964
Merged
Conversation
Many of the Managed methods accepted by-val parameters which could reference Limb slices that became invalid memory after any ensureCapacity calls. Now, Managed methods accept `*const Managed` parameters so that if the function allows aliasing and the ensure-capacity call resizes the Limb slice, it also affects the aliased parameters, avoiding use-after-free bugs. This is a breaking change that reduces the requirement for callsites to manually make the ensure-capacity changes prior to calling many of the Managed methods. Closes #11897
andrewrk
force-pushed
the
std-big-int-fixes
branch
from
2cc37bb to
14343b0
Compare
jedisct1
added
breaking
eyelash
reviewed
Jul 2, 2022
| /// | ||
| /// r and a may be aliases. If r aliases a, then caller must call | ||
| /// `r.ensureAddScalarCapacity` prior to calling `add`. | ||
| /// scalar is a primitive integer type. |
There was a problem hiding this comment.
Did you intend to delete this line or was it deleted accidentally?
Member
Author
There was a problem hiding this comment.
Intended. It was replaced with the sentence " r and a may be aliases". The other part is no longer a requirement of the caller.
There was a problem hiding this comment.
So scalar can now be something else than a primitive integer type?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many of the Managed methods accepted by-val parameters which could
reference Limb slices that became invalid memory after any
ensureCapacity calls. Now, Managed methods accept
*const Managedparameters so that if the function allows aliasing and the
ensure-capacity call resizes the Limb slice, it also affects the
aliased parameters, avoiding use-after-free bugs.
This is a breaking change that reduces the requirement for callsites to
manually make the ensure-capacity changes prior to calling many of the
Managed methods.
Closes #11897