llvm: fix missing global initializers in llvm module#13041
Closed
jacobly0 wants to merge 2 commits intoziglang:masterfrom
Closed
llvm: fix missing global initializers in llvm module#13041jacobly0 wants to merge 2 commits intoziglang:masterfrom
jacobly0 wants to merge 2 commits intoziglang:masterfrom
Conversation
jacobly0
force-pushed
the
llvm-global-init
branch
from
61bfe19 to
4dccfbf
Compare
jacobly0
force-pushed
the
llvm-global-init
branch
from
65e078a to
f8c7a4a
Compare
Member
|
I'm not sure this is right. When would we ever want to not codegen an initializer? |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12025 and #12588 by emitting a dummy initializer to catch various cases where we don't want to codegen one.