Closed
Conversation
kcbanner
reviewed
Jan 2, 2023
By factoring out the comptime parts of this computation, vectors are no longer useful in this function.
kubkon
reviewed
Jan 3, 2023
| /// If a new entry needs to be stored, this function asserts there | ||
| /// is enough capacity to store it. | ||
| pub fn getOrPutAssumeCapacityAdapted(self: *Self, key: anytype, ctx: anytype) GetOrPutResult { | ||
| return self.unmanaged.getOrPutAssumeCapacityAdapted(self.allocator, key, ctx); |
Member
There was a problem hiding this comment.
This slipped presumably because we didn't touch this bit in any test, correct? Perhaps it'd be good to add a smoke test to avoid this kind of regression in the future?
Member
|
Ready to merge? |
Member
|
Closing abandoned draft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for fixing the things I notice while doing a thing.