cmake: move 'continue' statement to avoid cmake bug#14182
Merged
andrewrk merged 1 commit intoziglang:masterfrom Jan 5, 2023
BratishkaErik:fix-cmake-1
Merged
cmake: move 'continue' statement to avoid cmake bug#14182andrewrk merged 1 commit intoziglang:masterfrom BratishkaErik:fix-cmake-1
andrewrk merged 1 commit intoziglang:masterfrom
BratishkaErik:fix-cmake-1
Conversation
Contributor
Author
|
@lamersc would you like to test if this cause regression or not? You just need to run head "https://github.com/ziglang/zig.git", branch: "master"to: head "https://github.com/BratishkaErik/zig.git", branch: "fix-cmake-1"And then build like regular zig |
andrewrk
requested changes
Jan 4, 2023
Will give it a test after classes 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks rather verbose (because we are workarounding https://gitlab.kitware.com/cmake/cmake/-/issues/22052 and because we did not have labelled loops in CMake), but at least it is touching less code than #14033 and should not cause regressions like #14093 (I unfortunately did not succeed in setting up macOS in VM, so this PR needs testing there)
Closes #14136