Update wasi-libc to 3189cd1ceec8771e8f27faab58ad05d4d6c369ef#15817
Merged
jedisct1 merged 4 commits intoziglang:masterfrom May 23, 2023
Merged
Update wasi-libc to 3189cd1ceec8771e8f27faab58ad05d4d6c369ef#15817jedisct1 merged 4 commits intoziglang:masterfrom
jedisct1 merged 4 commits intoziglang:masterfrom
Conversation
Also remove all the wasi-libc files we used to ship, but never compile.
jedisct1
added
os-wasi
wasi-libc now requiring explicit __wasilibc_populate_preopens() calls breaks too many things. We can deal with this after 0.11.
jedisct1
changed the title
Luukdegram
approved these changes
May 23, 2023
Contributor
Luukdegram
left a comment
Luukdegram
left a comment
There was a problem hiding this comment.
Always good to see code deleted :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also remove all the wasi-libc files we used to ship, but never compile.
The latest wasi-libc HEAD has an extra commit (a6f871343313220b76009827ed0153586361c0d5), which makes preopen initialization lazy: WebAssembly/wasi-libc#408
Unfortunately, that breaks quite a lot of things on our end. Applications now need to explicitly call
__wasilibc_populate_preopens()everywhere when the libc is linked. That can wait after 0.11.