cbe: support more symbol attributes#17180
Merged
andrewrk merged 1 commit intoziglang:masterfrom Sep 24, 2023
Merged
Conversation
cbfa4b7 to
c440027
Compare
jacobly0
requested changes
Sep 24, 2023
implement codegen for: - decl weak linkage - decl aliases - fn decl weak linkage windows msvc: - `__declspec(selectany)` is not supported for functions - skip weak linkage for functions closes ziglang#17050
c440027 to
fb929c0
Compare
jacobly0
approved these changes
Sep 24, 2023
fb929c0 to
50636ba
Compare
Member
|
I removed the zig1 update commit for now - will do that presently in #17253 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implement codegen for:
windows:
__declspec(selectany)is not supported for functionscloses #17050