sema: add union alignment resolution#17658
Merged
mlugg merged 3 commits intoziglang:masterfrom Oct 31, 2023
Merged
Conversation
kcbanner
force-pushed
the
union_alignment_resolution
branch
from
c906f37 to
1e6ecf8
Compare
mlugg
reviewed
Oct 25, 2023
Member
mlugg
left a comment
mlugg
left a comment
There was a problem hiding this comment.
Actual logic looks good, a few minor comments.
kcbanner
force-pushed
the
union_alignment_resolution
branch
from
1e6ecf8 to
ac52cb9
Compare
mlugg
reviewed
Oct 26, 2023
- Add resolveUnionAlignment, to resolve a union's alignment only, without triggering layout resolution. - Update resolveUnionLayout to cache size, alignment, and padding. abiSizeAdvanced and abiAlignmentAdvanced now use this information instead of computing it each time.
… guess was correct
kcbanner
force-pushed
the
union_alignment_resolution
branch
from
ac52cb9 to
0574643
Compare
mlugg
approved these changes
Oct 27, 2023
Member
mlugg
left a comment
mlugg
left a comment
There was a problem hiding this comment.
Nice work! I'd be happy to merge this, but I'll give it a couple days in case Andrew has any comments I've missed.
Member
|
@mlugg please prefer a
|
Member
|
Ah, okay, my bad! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just the union alignment changes extracted from #17490.
Changes:
resolveUnionAlignment, to resolve a union's alignment only, without triggering layout resolution.resolveUnionLayoutto cache size, alignment, and padding.abiSizeAdvancedandabiAlignmentAdvancednow use this information instead of computing it each time.