Skip to content

Fix Stat.ctime docs, and correct its value on Windows #18323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vexu merged 1 commit into from
Dec 20, 2023
Merged

Fix Stat.ctime docs, and correct its value on Windows #18323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/std/fs/File.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,11 +315,11 @@ pub const Stat = struct {
mode: Mode,
kind: Kind,

/// Access time in nanoseconds, relative to UTC 1970-01-01.
/// Last access time in nanoseconds, relative to UTC 1970-01-01.
atime: i128,
/// Last modification time in nanoseconds, relative to UTC 1970-01-01.
mtime: i128,
/// Creation time in nanoseconds, relative to UTC 1970-01-01.
/// Last status/metadata change time in nanoseconds, relative to UTC 1970-01-01.
ctime: i128,

pub fn fromSystem(st: posix.system.Stat) Stat {
Expand Down Expand Up @@ -369,6 +369,8 @@ pub const Stat = struct {

pub const StatError = posix.FStatError;

/// Returns `Stat` containing basic information about the `File`.
/// Use `metadata` to retrieve more detailed information (e.g. creation time, permissions).
/// TODO: integrate with async I/O
pub fn stat(self: File) StatError!Stat {
if (builtin.os.tag == .windows) {
Expand All @@ -392,7 +394,7 @@ pub fn stat(self: File) StatError!Stat {
.kind = if (info.StandardInformation.Directory == 0) .file else .directory,
.atime = windows.fromSysTime(info.BasicInformation.LastAccessTime),
.mtime = windows.fromSysTime(info.BasicInformation.LastWriteTime),
.ctime = windows.fromSysTime(info.BasicInformation.CreationTime),
.ctime = windows.fromSysTime(info.BasicInformation.ChangeTime),
};
}

Expand Down