Conversation
davidgmbb
force-pushed
the
respect-error-return-trace
branch
from
5eed141 to
d28baf0
Compare
andrewrk
left a comment
andrewrk
left a comment
There was a problem hiding this comment.
std.os.unexpected_error_tracing has nothing to do with whether error return tracing is enabled.
Instead I suggest to make this configurable via std.Options.
davidgmbb
force-pushed
the
respect-error-return-trace
branch
from
d28baf0 to
8ea51bf
Compare
Without this patch, the stack trace code would still be pulled to the binary, increasing the binary size by a huge amount and thus increasing compilation time. Now the user's choice is respected and no stack trace code is being pulled when the user choses not to have unexpected error traces
davidgmbb
force-pushed
the
respect-error-return-trace
branch
from
8ea51bf to
f222056
Compare
|
I'm sorry, I didn't review this in time, and now it has bitrotted. Furthermore, so many pull requests have stacked up that I can't keep up and I am therefore declaring Pull Request Bankruptcy and closing old PRs that now have conflicts with master branch. If you want to reroll, you are by all means welcome to revisit this changeset with respect to the current state of master branch, and there's a decent chance your patch will be reviewed the second time around. Either way, I'm closing this now, otherwise the PR queue will continue to grow indefinitely. |
3 participants
Without this patch, the stack trace code would still be pulled to the binary, increasing the binary size by a huge amount and thus increasing compilation time. Now the user's choice is respected and no stack trace code is being pulled when the user choses not to have error traces