Skip to content

std.{ArrayList,ArrayHashMap,MultiArrayList,BoundedArray}: popOrNull() -> pop()#19424

Closed
nektro wants to merge 5 commits intoziglang:masterfrom
nektro:nektro-patch-33259
Closed

std.{ArrayList,ArrayHashMap,MultiArrayList,BoundedArray}: popOrNull() -> pop()#19424
nektro wants to merge 5 commits intoziglang:masterfrom
nektro:nektro-patch-33259

Conversation

@nektro
Copy link
Contributor

@nektro nektro commented Mar 24, 2024

No description provided.

@nektro nektro force-pushed the nektro-patch-33259 branch from dec67ec to d24b25e Compare April 2, 2024 11:36
@nektro nektro changed the title std.{ArrayList,ArrayHashMap,MultiArrayList}: popOrNull() -> pop() std.{ArrayList,ArrayHashMap,MultiArrayList,BoundedArray}: popOrNull() -> pop() Apr 2, 2024
@thejoshwolfe
Copy link
Contributor

is there a discussion of this elsewhere i can read? what's the motivation for this change?

@nektro
Copy link
Contributor Author

nektro commented Apr 6, 2024

#19406 (comment) and that having both Is redundant

@nektro
Copy link
Contributor Author

nektro commented Apr 7, 2024

carefully looked over my code again and didn't see anything that stuck out that seemed to be the cause of the CI issue i'm seeing, which i unfortunately believe is a bug in the c backend. will try to reproduce separately.

@nektro
Copy link
Contributor Author

nektro commented Apr 7, 2024

if the type names are correct its while using a std.AutoArrayHashMapUnmanaged(void, void)

@andrewrk
Copy link
Member

andrewrk commented May 9, 2024

CI checks failing; no update in 30+ days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants