Skip to content

fetch: combine unpack error validation in a single function#19618

Merged
andrewrk merged 1 commit intoziglang:masterfrom
ianic:19500_follow_up
Apr 11, 2024
Merged

fetch: combine unpack error validation in a single function#19618
andrewrk merged 1 commit intoziglang:masterfrom
ianic:19500_follow_up

Conversation

@ianic
Copy link
Contributor

@ianic ianic commented Apr 11, 2024

Follow up of: #19500
discussion

@andrewrk
Copy link
Member

I like it this way. What do you think?

@ianic
Copy link
Contributor Author

ianic commented Apr 11, 2024

I was worried that this one will be harder to test but that was not the problem at the end.
Now all validate is covered. In that sense I like it more.

I also found a bug in previous implementation. Here I'm iterating over all errors but should use only non filtered something like self.errors[0..self.errors_count].

@andrewrk andrewrk enabled auto-merge (rebase) April 11, 2024 21:43
@andrewrk andrewrk merged commit 9cfac47 into ziglang:master Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants