Skip to content

zig2: [mingw] allocate enough memory when building zig2#20514

Merged
andrewrk merged 1 commit intoziglang:masterfrom
raedrizqie:mingw-zig2
Jul 16, 2024
Merged

zig2: [mingw] allocate enough memory when building zig2#20514
andrewrk merged 1 commit intoziglang:masterfrom
raedrizqie:mingw-zig2

Conversation

@raedrizqie
Copy link
Contributor

No description provided.

@andrewrk andrewrk enabled auto-merge (rebase) July 9, 2024 23:22
@andrewrk
Copy link
Member

andrewrk commented Jul 9, 2024

Thank you

@raedrizqie
Copy link
Contributor Author

raedrizqie commented Jul 10, 2024

[18/20] Linking CXX executable zig2.exe
FAILED: zig2.exe 
C:\Windows\system32\cmd.exe /C "cd . && C:\Users\ci\zig+llvm+lld+clang-x86_64-windows-gnu-0.13.0-dev.130+98a30acad\bin\zig.exe c++ -target x86_64-windows-gnu -mcpu=baseline -O3 -DNDEBUG -Wl,--stack,0x10000000 -Wl,--large-address-aware @CMakeFiles\zig2.rsp -o zig2.exe -Wl,--out-implib,libzig2.dll.a -Wl,--major-image-version,0,--minor-image-version,0 && cd ."
error: unsupported linker arg: --large-address-aware

ah.. zig was used to build zig2..

auto-merge was automatically disabled July 11, 2024 12:00

Head branch was pushed to by a user without write access

@andrewrk andrewrk merged commit 9356cb1 into ziglang:master Jul 16, 2024
@raedrizqie
Copy link
Contributor Author

thanks!

@raedrizqie raedrizqie deleted the mingw-zig2 branch July 16, 2024 07:46
@alexrp
Copy link
Member

alexrp commented Apr 2, 2025

@raedrizqie @andrewrk what was this actually fixing? --maxrss defaults to the total system memory. We don't pass --maxrss explicitly anywhere in the build system, only in the Linux CI scripts. Also ZIG_BUILD_ARGS is used when invoking zig2 to build zig3. Fairly confused about this one.

@raedrizqie
Copy link
Contributor Author

@alexrp It was added for building zig without bootstrap for MSYS2 UCRT 32-bit system not long ago. Now, MSYS2 has drop 32-bit UCRT system on their repo, it is safe to revert this commit. Thank you.

dasimmet pushed a commit to dasimmet/zig that referenced this pull request Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants