Fix compile error due to GetModuleFileNameW binding change#20861
Merged
andrewrk merged 1 commit intoziglang:masterfrom Jul 29, 2024
Merged
Fix compile error due to GetModuleFileNameW binding change#20861andrewrk merged 1 commit intoziglang:masterfrom
andrewrk merged 1 commit intoziglang:masterfrom
Conversation
In ziglang#19641, this binding changed from `[*]u16` to `LPWSTR` which made it a sentinel-terminated pointer. This introduced a compiler error in the `std.os.windows.GetModuleFileNameW` wrapper since it takes a `[*]u16` pointer. This commit changes the binding back to what it was before instead of introducing a breaking change to `std.os.windows.GetModuleFileNameW` Related: ziglang#20858
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #19641 (cc @The-King-of-Toasters), this binding changed from
[*]u16toLPWSTRwhich made it a sentinel-terminated pointer. This introduced a compile error in thestd.os.windows.GetModuleFileNameWwrapper since it takes a[*]u16pointer. This commit changes the binding back to what it was before instead of introducing a breaking change tostd.os.windows.GetModuleFileNameWRelated: #20858
Note: Neither
std.os.windows.kernel32.GetModuleFileNameWnorstd.os.windows.GetModuleFileNameWis used by Zig internally (instead,std.os.windows.kernel32.GetModuleFileNameExWis used instd.debug). So an alternate fix here might be to just delete the binding and the wrapper instd.os.windows.