gen_stubs: Add complete coverage for all (non-ILP32) arches.#20943
Closed
alexrp wants to merge 1 commit intoziglang:masterfrom
alexrp:gen-stubs
Closed
gen_stubs: Add complete coverage for all (non-ILP32) arches.#20943alexrp wants to merge 1 commit intoziglang:masterfrom alexrp:gen-stubs
gen_stubs: Add complete coverage for all (non-ILP32) arches.#20943alexrp wants to merge 1 commit intoziglang:masterfrom
alexrp:gen-stubs
Conversation
alexrp
commented
Aug 4, 2024
| fn archIndex(arch: std.Target.Cpu.Arch) u8 { | ||
| return switch (arch) { | ||
| // zig fmt: off | ||
| .riscv64 => 0, |
Member
Author
There was a problem hiding this comment.
I'm unsure if the the indexes that were assigned here previously had significance. If they did, I can revert this part and add the new arches at 10-12.
Member
|
Those are missing because I was unable to get them to build: https://github.com/ziglang/zig/wiki/Updating-libc#updating-the-libcs-file |
Member
Author
|
Ok, I'll try those and see if they work now. At least the s390x error should be fixed by #20451. Not sure about arm and m68k. |
Member
Author
Well, I guess let's leave this PR until the LLVM 19 upgrade and then re-evaluate? |
Member
Author
|
Closing for now; will retry the above after we upgrade to LLVM 19, and then reopen if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, we were missing arm, m68k, and s390x.