Follow-up on std.Target GPU changes in #20960#20985
Merged
andrewrk merged 8 commits intoziglang:masterfrom Aug 12, 2024
alexrp:gpu-nonsense
Merged
Follow-up on std.Target GPU changes in #20960#20985andrewrk merged 8 commits intoziglang:masterfrom alexrp:gpu-nonsense
std.Target GPU changes in #20960#20985andrewrk merged 8 commits intoziglang:masterfrom
alexrp:gpu-nonsense
Conversation
Member
Author
|
cc @Snektron |
std.Target GPU changes in #20960
Snektron
approved these changes
Aug 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std.Target: A bunch of C type size/alignment fixes #20960 was flawed for GPUs due to using-xcinstead of-xclor-xhip, etc. So I'm reverting most of the GPU-related changes, save for 23b5a6c which is correct as far as I can tell.sizeof(long double) = 16for AMDHSA seems quite suspicious. But having spent a whole day digging through this GPU nonsense and ending up not much wiser than when I started, I'm deciding to just leave it alone until someone actually exercises these code paths in the real world.std.Target: A bunch of C type size/alignment fixes #20960 (again, due to the flawed methodology).spir/spir64after all. I can't find much evidence that this saw notable real world use even before the introduction of SPIR-V in 2015. Can always add them back if demand materializes.