libfuzzer: Track the rate of fuzzing in cycles/s.#21025
Closed
gcoakes wants to merge 2 commits intoziglang:masterfrom
Closed
libfuzzer: Track the rate of fuzzing in cycles/s.#21025gcoakes wants to merge 2 commits intoziglang:masterfrom
gcoakes wants to merge 2 commits intoziglang:masterfrom
Conversation
Contributor
|
This statistic can be entierly calculated on the webui instead of calculating it in the fuzz process if you make the webserver send periodic updates instead of only on new unique input like it is now. |
andrewrk
requested changes
Aug 29, 2024
Member
andrewrk
left a comment
andrewrk
left a comment
There was a problem hiding this comment.
Agreed, it should be calculated client side.
As libfuzzer develops or as users design their own fuzz tests which use libfuzzer, it will be essential to understand the performance impact of changes. This change tracks the rate of execution in terms of cycles per second and updates the UI at most every second. This is implemented with a periodic update to the web UI which occurs at least every 1 second. The period is not guaranteed to be regular.
Contributor
Author
andrewrk
requested changes
Sep 10, 2024
| last_cycle_timed.* = n_runs; | ||
|
|
||
| try web_socket.writeMessage(std.mem.asBytes(&abi.PeriodicUpdateHeader{ | ||
| .cycles_per_second = cycles_per_second, |
Member
There was a problem hiding this comment.
it should be calculated client side.
the only additional thing that needs to be sent by the server is two pieces of static data that are already known when the connection is made:
- what time the server thinks it currently is
- what time according to the server fuzzing started
then the client can do the calculation based on what time it is currently and the number of runs.
DivergentClouds
pushed a commit
to DivergentClouds/zig
that referenced
this pull request
Sep 24, 2024
richerfu
pushed a commit
to richerfu/zig
that referenced
this pull request
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As libfuzzer develops or as users design their own fuzz tests which use libfuzzer, it will be essential to understand the performance impact of changes. This change tracks the rate of execution in terms of cycles per second and updates the UI at most every second.