Open
Conversation
linusg
reviewed
Sep 9, 2024
linusg
reviewed
Sep 9, 2024
Collaborator
linusg
left a comment
linusg
left a comment
There was a problem hiding this comment.
My review doesn't mean much here but stylistic changes LGTM, thanks :)
Contributor
Author
|
Hello there, i just updated my branch. Is there anyone to review this? |
Arwalk
force-pushed
the
master
branch
2 times, most recently
from
dcef5f0 to
f4fd478
Compare
InKryption
reviewed
Nov 15, 2024
Contributor
Author
|
Hey there. Is there anything missing for this to be merged? It has been open for a bit of time. I'm not blaming anyone or being mean about it, I'm sure there are much more pressing matters than this, but i'd still like it to be merged at some point :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decoding part related to #20961.
This proposes stream-friendly interface for base64 decoding (decoding to stream, decoding from read stream to write stream).
While writing this, i realized the original base64 decoder with ignored characters was doing some semi-complicated stuff to keep track of its decoding state. This rewrites the original decoder to rely on the decoder without ignores, moving the track keeping to simply chunking 4 valid characters using streams. This should be equivalent in performances and do not requires memory allocation either.