Get module tests passing for s390x-linux and add it to CI#21578
Merged
alexrp merged 6 commits intoziglang:masterfrom Oct 4, 2024
alexrp:s390x-porting
Merged
Get module tests passing for s390x-linux and add it to CI#21578alexrp merged 6 commits intoziglang:masterfrom alexrp:s390x-porting
s390x-linux and add it to CI#21578alexrp merged 6 commits intoziglang:masterfrom
alexrp:s390x-porting
Conversation
andrewrk
requested changes
Oct 3, 2024
andrewrk
approved these changes
Oct 3, 2024
Member
andrewrk
left a comment
andrewrk
left a comment
There was a problem hiding this comment.
Thanks. I think that's a lot better.
I think it's better to not paper over problems such as the duplicated code in thread-local storage init there. For example, now it makes a stronger case for a language feature such as recursive-inline at the callsite, whether or not we end up going that route.
The s390x mmap() syscall existed before Linux supported syscalls with 5+ parameters, so it takes a single pointer to an array of arguments instead.
On s390x-linux, fstat() does not have nanosecond precision, but fstatat() does. As a result, comparing Stat structs returned from these syscalls is doomed to fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #21037 to produce working
s390x-linux-gnubinaries;s390x-linux-noneands390x-linux-muslwork regardless.ref: #21402