Skip to content

tests: re-enable tests that now pass on aarch64-windows #21769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexrp merged 1 commit into from
Oct 22, 2024
Merged

tests: re-enable tests that now pass on aarch64-windows #21769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions test/behavior/align.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,11 +281,6 @@ test "page aligned array on stack" {
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
if (builtin.zig_backend == .stage2_spirv64) return error.SkipZigTest;

if (builtin.cpu.arch == .aarch64 and builtin.os.tag == .windows) {
// https://github.com/ziglang/zig/issues/13679
return error.SkipZigTest;
}

// Large alignment value to make it hard to accidentally pass.
var array align(0x1000) = [_]u8{ 1, 2, 3, 4, 5, 6, 7, 8 };
var number1: u8 align(16) = 42;
Expand Down
4 changes: 0 additions & 4 deletions test/behavior/basic.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1174,10 +1174,6 @@ test "arrays and vectors with big integers" {
if (builtin.zig_backend == .stage2_spirv64) return error.SkipZigTest;
if (builtin.zig_backend == .stage2_riscv64) return error.SkipZigTest;

// TODO: only aarch64-windows didn't pass in the PR that added this code.
// figure out why if you can run this target.
if (builtin.os.tag == .windows and builtin.cpu.arch == .aarch64) return error.SkipZigTest;

inline for (.{ u65528, u65529, u65535 }) |Int| {
var a: [1]Int = undefined;
a[0] = std.math.maxInt(Int);
Expand Down
7 changes: 0 additions & 7 deletions test/behavior/cast.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2504,13 +2504,6 @@ test "@intFromBool on vector" {
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
if (builtin.zig_backend == .stage2_riscv64) return error.SkipZigTest;

if (builtin.zig_backend == .stage2_llvm and
builtin.cpu.arch == .aarch64 and builtin.os.tag == .windows)
{
// https://github.com/ziglang/zig/issues/19825
return error.SkipZigTest;
}

const S = struct {
fn doTheTest() !void {
var a: @Vector(3, bool) = .{ false, true, false };
Expand Down
2 changes: 0 additions & 2 deletions test/behavior/generics.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,8 +532,6 @@ test "call generic function with from function called by the generic function" {
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
if (builtin.zig_backend == .stage2_llvm and
builtin.cpu.arch == .aarch64 and builtin.os.tag == .windows) return error.SkipZigTest;

const GET = struct {
key: []const u8,
Expand Down
7 changes: 0 additions & 7 deletions test/behavior/shuffle.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,13 +140,6 @@ test "@shuffle bool 1" {
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
if (builtin.zig_backend == .stage2_riscv64) return error.SkipZigTest;

if (builtin.zig_backend == .stage2_llvm and
builtin.cpu.arch == .aarch64 and builtin.os.tag == .windows)
{
// https://github.com/ziglang/zig/issues/19824
return error.SkipZigTest;
}

const S = struct {
fn doTheTest() !void {
var x: @Vector(4, bool) = [4]bool{ false, true, false, true };
Expand Down