wasm: Pass --allow-undefined and --export-all to the linker#2193
Merged
andrewrk merged 1 commit intoziglang:masterfrom Apr 5, 2019
Merged
wasm: Pass --allow-undefined and --export-all to the linker#2193andrewrk merged 1 commit intoziglang:masterfrom
andrewrk merged 1 commit intoziglang:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is ugly but does fix #1622 and we get seamless WebAssembly experience out of the box.
Edit: Just read the full nuances in the issue. I was too excited to get things working out of the box. Feel free to close the pull request if this doesn't cut it.