Fix std.mem.orderZ for types for which 0 is not the least element#22618
Open
Fri3dNstuff wants to merge 1 commit intoziglang:masterfrom
Open
Fix std.mem.orderZ for types for which 0 is not the least element#22618Fri3dNstuff wants to merge 1 commit intoziglang:masterfrom
std.mem.orderZ for types for which 0 is not the least element#22618Fri3dNstuff wants to merge 1 commit intoziglang:masterfrom
Conversation
std.mem.orderZ for types for which 0 is not the least numberstd.mem.orderZ for types for which 0 is not the least element
Contributor
Author
|
There's still the issue of floating point numbers to be discussed: IEEE-754 (in its infinite wisdom...) declares std.mem.orderZ(f32, &.{ 1.0, 2.0 }, &.{ 1.0, 2.0, -0.0 })Should this be addressed? If so, other functions operating on sentinel-terminated values ( |
IOKG04
added a commit
to IOKG04/zig
that referenced
this pull request
Aug 3, 2025
closes ziglang#22618 (from where i stole the code) i don't think this syntax will work with pull requests, but i can try at least :3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an oversight in
std.mem.orderZthat caused the function to sometimes produce wrong results for slices of signed integers and floats.Added test case: