add dependent modules regardless of whether a runner was specified#23626
Closed
elerch wants to merge 1 commit intoziglang:masterfrom
Closed
add dependent modules regardless of whether a runner was specified#23626elerch wants to merge 1 commit intoziglang:masterfrom
elerch wants to merge 1 commit intoziglang:masterfrom
Conversation
Member
|
Needs a rebase to resolve conflicts. |
Contributor
Author
|
rebased onto a14352b |
Member
|
I think this may already be fixed on master thanks to #23836. Will test shortly. |
Member
|
Confirmed already fixed. Thank you though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #23610 and very possibly #23453. The diff is semanticly equivalent to this diff, just cleaned up to remove the block that became unnecessary. All behavior tests pass.