std.fmt: migrate bufPrintZ to bufPrintSentinel#25260
Merged
linusg merged 3 commits intoziglang:masterfrom Sep 19, 2025
Merged
Conversation
andrewrk
requested changes
Sep 18, 2025
Member
andrewrk
left a comment
andrewrk
left a comment
There was a problem hiding this comment.
Thanks, one thing to address and then it can be merged.
| pub fn bufPrintZ(buf: []u8, comptime fmt: []const u8, args: anytype) BufPrintError![:0]u8 { | ||
| const result = try bufPrint(buf, fmt ++ "\x00", args); | ||
| return result[0 .. result.len - 1 :0]; | ||
| pub fn bufPrintSentinel( |
Member
There was a problem hiding this comment.
Since this is a breaking change, it should have an alias for one release cycle before being deleted.
Suggested change
| pub fn bufPrintSentinel( | |
| /// Deprecated in favor of `bufPrintSentinel` | |
| pub const bufPrintZ = bufPrintSentinel; | |
| pub fn bufPrintSentinel( |
Contributor
There was a problem hiding this comment.
Sorry if I wrong, but shouldn't it be done as function, not alias? Because signature differs by one argument(comptime sentinel: u8)
andrewrk
approved these changes
Sep 18, 2025
andrewrk
added
breaking
Collaborator
|
Disabled auto-merge as per @StAlKeR7779's comment. |
Contributor
Author
Collaborator
|
Yeah, that looks good. Thanks! |
Member
|
Sorry, bad suggestion to make it an alias! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed
std.fmt.allocPrintSentineland migratedbufPrintZtobufPrintSentinelto match.