zig fmt: preserve formatting for function parameters with doc comments#25274
Open
jedisct1 wants to merge 2 commits intoziglang:masterfrom
Open
zig fmt: preserve formatting for function parameters with doc comments#25274jedisct1 wants to merge 2 commits intoziglang:masterfrom
jedisct1 wants to merge 2 commits intoziglang:masterfrom
Conversation
Previously, zig fmt would collapse function declarations with doc comments
onto a single line, creating invalid syntax like:
```zig
fn foo(/// comment
_: void) void {}
```
Now we check for doc comments between parentheses and prevent the
single-line formatting when doc comments are present, ensuring proper
line separation and adding trailing comma when needed.
Fixes ziglang#18088
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, zig fmt would collapse function declarations with doc comments onto a single line, creating invalid syntax like:
Now we check for doc comments between parentheses and prevent the single-line formatting when doc comments are present, ensuring proper line separation and adding trailing comma when needed.
Fixes #18088
Fixes #25267