Skip to content

Windows: Fix std.fs.Dir.deleteDir() deleting files#5538

Merged
andrewrk merged 1 commit intoziglang:masterfrom
squeek502:win-deletedir
Jun 5, 2020
Merged

Windows: Fix std.fs.Dir.deleteDir() deleting files#5538
andrewrk merged 1 commit intoziglang:masterfrom
squeek502:win-deletedir

Conversation

@squeek502
Copy link
Member

@squeek502 squeek502 commented Jun 4, 2020 •
edited
Loading

Would previously delete files, now correctly returns error.NotDir. Fixes #5536

@squeek502
Windows: Fix std.fs.Dir.deleteDir() deleting files
b2982c2 
Would previously delete files, now correctly returns error.NotDir. Fixes ziglang#5536
@andrewrk
Copy link
Member

andrewrk commented Jun 5, 2020

Thanks for the fix! Would be nice to add test coverage for this but the fix alone is welcome too

@andrewrk andrewrk merged commit f7b6957 into ziglang:master Jun 5, 2020
@squeek502
Copy link
Member Author

squeek502 commented Jun 5, 2020 •
edited
Loading

Would be nice to add test coverage for this

Agreed. All of std.fs (and other fs related stuff) is rather undertested imo; might take a stab at improving coverage overall at some point.

@daurnimator daurnimator added os-windows Microsoft Windows standard library This issue involves writing Zig code for the standard library. labels Jun 8, 2020
@squeek502 squeek502 mentioned this pull request Jun 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

os-windows Microsoft Windows standard library This issue involves writing Zig code for the standard library.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows: std.fs.Dir.deleteDir() will delete files

3 participants

@squeek502 @andrewrk @daurnimator