Adding 2 new messages 0x8012 and 0x9999 #107
Conversation
|
@doudz , don't where the changes on Application.py are coming from. |
doudz
left a comment
doudz
left a comment
There was a problem hiding this comment.
Could you also add a unit test to validate two stages pairing ?
| 0x8007: (t.uint8_t,), | ||
| 0x8009: (t.NWK, t.EUI64, t.uint16_t, t.uint64_t, t.uint8_t), | ||
| 0x8010: (t.uint16_t, t.uint16_t), | ||
| 0x8012: (t.uint8_t, t.uint8_t, t.uint8_t, t.Address, t.uint8_t), |
| ieee = zigpy.types.EUI64(response[1]) | ||
| parent_nwk = 0 | ||
| self.handle_join(nwk, ieee, parent_nwk) | ||
| #time.sleep(2.0) |
There was a problem hiding this comment.
Please remove commented line
| parent_nwk = 0 | ||
| self.handle_join(nwk, ieee, parent_nwk) | ||
| #time.sleep(2.0) | ||
| #self.handle_join(nwk, ieee, parent_nwk) |
| # else: | ||
| # LOGGER.debug('Start pairing {} (1st device announce)'.format(nwk)) | ||
| # self._pending_join.append(nwk) | ||
| rejoin = response[3] |
There was a problem hiding this comment.
You should also update line 47 to set minimal firmware to 3.2
| 0x8701: (t.uint8_t, t.uint8_t), | ||
| 0x8702: (t.uint8_t, t.uint8_t, t.uint8_t, t.Address, t.uint8_t), | ||
| 0x8806: (t.uint8_t,), | ||
| 0x9999: (t.uint8_t,), |
There was a problem hiding this comment.
You should also handle the message with logger
|
we are currently working on zigpy-zigate library under a fork dedicated to our project, we don't have the possibility to test it under the ZHA environment but if you are ready to do, you can eventually use it When ready we will be providing PRs against the main stream |
2 participants
No description provided.