add Unnecessary tag to unused var diagnostics#2387
Merged
Techatrix merged 1 commit intozigtools:masterfrom Jul 10, 2025
Merged
Conversation
The-Briel-Deal
force-pushed
the
zls_unnecessary_diagnostics
branch
from
c00063e to
76d60f1
Compare
Techatrix
requested changes
Jul 7, 2025
Techatrix
reviewed
Jul 7, 2025
The-Briel-Deal
force-pushed
the
zls_unnecessary_diagnostics
branch
4 times, most recently
from
d2ed12a to
06646bf
Compare
Techatrix
requested changes
Jul 8, 2025
The-Briel-Deal
force-pushed
the
zls_unnecessary_diagnostics
branch
from
06646bf to
e5bf19b
Compare
The-Briel-Deal
force-pushed
the
zls_unnecessary_diagnostics
branch
from
e5bf19b to
843420f
Compare
Contributor
Author
|
It looks to me like CI was failing on the last run because I didn't have the version tags on my fork. All tests run from |
Member
|
There has been a recent breaking change in Zig which has caused the CI to fail. This will be addressed soon by #2394. |
Contributor
Author
Ok thats good to hear, I just wanted to make sure it wasn't a problem on my side. |
Problem: Currently unused var and const declarations produce a diagnostic error without `lsp.types.DiagnosticTag.Unnecessary`. This means that editors can't visually display that a variable is unused by dimming the highlight on the variable. Solution: When `ast-check` produces a "unused local constant" or "unused local variable" diagnostic, we should add the Unnecessary tag to the LSP diagnostic.
Techatrix
force-pushed
the
zls_unnecessary_diagnostics
branch
from
843420f to
879f347
Compare
Techatrix
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Currently unused var and const declarations produce a diagnostic error without
lsp.types.DiagnosticTag.Unnecessary. This means that editors can't visually display that a variable is unused by dimming the highlight on the variable.Solution: When
ast-checkproduces a "unused local constant" or "unused local variable" diagnostic, we should add the Unnecessary tag to the LSP diagnostic.