Add parameters of aws opensearch, support hnsw engine options, support multi-client load data by norrishuang · Pull Request #527 · zilliztech/VectorDBBench

norrishuang · 2025-05-21T15:18:19Z

Add aws opensearch parameters of hnsw engine options, space type options.
Add multi-client load data for aws opensearch.
Support set FP16 for faiss engine.
Add parameters of shards/replicas/indexing clients/hnsw engine options in UI.

command example

vectordbbench awsopensearch --db-label aos --task-label task-001 \  
--m 16 --ef-construction 256 --ef-search 200 \
--host <aos-host> --port 443 \
--user admin --password '<password>' \
--case-type Performance768D10M \
--number-of-shards 9  \
--number-of-replicas 1 \
--number-of-indexing-clients 10 \
--engine faiss --metric-type ip \
--no-faiss-use-fp16 \
--load --drop-old --num-concurrency 100

and from UI

result log
result_20250521_ef-search-100_opensearch.json

…dexConfig index_thread_qty_during_force_merge

…eters of hnsw engine and metric-type.

alwayslove2013 · 2025-05-22T01:44:45Z

@norrishuang Thank you very much for your so detailed PR. I believe it will help the community test OpenSearch more effectively, and I will review it as soon as possible.

navneet1v · 2025-05-25T03:53:31Z

@norrishuang similar PR: https://github.com/zilliztech/VectorDBBench/pull/529/files with fixes and removal nmslib engine since it is deprecated.

navneet1v · 2025-05-25T03:54:19Z

vectordb_bench/backend/clients/aws_opensearch/config.py

-                log.info(
-                    "Using innerproduct because faiss doesn't support cosine as metric type for Opensearch",
-                )
+                log.info("Using innerproduct because faiss doesn't support cosine as metric type for Opensearch")


cosine is supported with 2.19 and above version of Opensearch with faiss. I think this check can be removed

Thanks @navneet1v , I removed it.

alwayslove2013 · 2025-05-27T10:38:05Z

vectordb_bench/backend/clients/aws_opensearch/config.py

    engine: AWSOS_Engine = AWSOS_Engine.faiss
    efConstruction: int = 256
    efSearch: int = 256
+    ef_search: int = 200


How about removing one of efSearch or ef_search?

removed efSearch in commit recover some code format

alwayslove2013 · 2025-05-27T10:40:56Z

@norrishuang There is an issue with the format.
Hope it helps.

pip install ruff --upgrade
pip install black --upgrade
make format
make lint

norrishuang · 2025-05-27T23:20:14Z

fixed format issue. recover some code format

alwayslove2013 · 2025-06-09T01:32:24Z

@norrishuang some little conflicts with pr: #529 , could you please help resolve it~

norrishuang · 2025-06-10T01:38:02Z

@norrishuang some little conflicts with pr: #529 , could you please help resolve it~

The conflicts was resolved.

sre-ci-robot · 2025-06-10T01:50:44Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alwayslove2013, norrishuang
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

alwayslove2013 · 2025-06-10T01:53:33Z

@norrishuang still seems to conflict with main.

norrishuang · 2025-06-10T02:18:24Z

@norrishuang still seems to conflict with main.

compare the code of conflicts, there are some code format issues, it's resolved.

…t multi-client load data (zilliztech#527) * fix error of OpenSearch frontend:Validation error for AWSOpenSearchIndexConfig index_thread_qty_during_force_merge * add parameters of aws opensearch in frontend. * fiexd issue of opensearch ui and add multi-client indexing, add parameters of hnsw engine and metric-type. * fiexd issue of opensearch ui and add multi-client indexing, add parameters of hnsw engine and metric-type. * fiexd issue of opensearch ui and add multi-client indexing, add parameters of hnsw engine and metric-type. * clean logs * clean comments * clean logs * clean comments * fixed some issue, add warmup before search test only. * fixed some issue of create index and mulit-client * support faiss fp16 * clear comment * recover some code format * recover some code format * recover some code format * recover some code format * recover some code format * resolved conflict with pr: zilliztech#529

norrishuang added 16 commits May 14, 2025 14:00

fix error of OpenSearch frontend:Validation error for AWSOpenSearchIn…

fdeb572

…dexConfig index_thread_qty_during_force_merge

add parameters of aws opensearch in frontend.

aa0da63

fiexd issue of opensearch ui and add multi-client indexing, add param…

58f60d5

…eters of hnsw engine and metric-type.

fiexd issue of opensearch ui and add multi-client indexing, add param…

7f466f3

…eters of hnsw engine and metric-type.

fiexd issue of opensearch ui and add multi-client indexing, add param…

23684a6

…eters of hnsw engine and metric-type.

clean logs

9067a04

clean comments

5256e70

clean logs

83f4287

clean comments

5818efa

fixed some issue, add warmup before search test only.

bb5dd09

fixed some issue of create index and mulit-client

e73d694

support faiss fp16

ca14e43

clear comment

55146ad

recover some code format

aa0808b

recover some code format

f257cab

recover some code format

0e5a24e

norrishuang marked this pull request as ready for review May 21, 2025 15:19

alwayslove2013 self-assigned this May 22, 2025

alwayslove2013 self-requested a review May 22, 2025 01:44

navneet1v reviewed May 25, 2025

View reviewed changes

alwayslove2013 reviewed May 27, 2025

View reviewed changes

recover some code format

9506a25

Merge branch 'main' into aws-opensearch

791aa54

alwayslove2013 approved these changes Jun 10, 2025

View reviewed changes

norrishuang added 2 commits June 10, 2025 10:02

recover some code format

68ec046

resolved conflict with pr: zilliztech#529

32d3cc4

alwayslove2013 merged commit cb707d5 into zilliztech:main Jun 11, 2025
4 checks passed

Conversation

norrishuang commented May 21, 2025

Uh oh!

alwayslove2013 commented May 22, 2025

Uh oh!

navneet1v commented May 25, 2025

Uh oh!

navneet1v May 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

norrishuang May 27, 2025

Choose a reason for hiding this comment

Uh oh!

alwayslove2013 May 27, 2025

Choose a reason for hiding this comment

Uh oh!

norrishuang May 27, 2025

Choose a reason for hiding this comment

Uh oh!

alwayslove2013 commented May 27, 2025

Uh oh!

norrishuang commented May 27, 2025

Uh oh!

alwayslove2013 commented Jun 9, 2025

Uh oh!

norrishuang commented Jun 10, 2025

Uh oh!

sre-ci-robot commented Jun 10, 2025

Uh oh!

alwayslove2013 commented Jun 10, 2025

Uh oh!

norrishuang commented Jun 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

navneet1v May 25, 2025 •

edited

Loading