Add Chroma cli to VectorDBBench#610
Conversation
|
/assign @XuanYang-cn |
| return { | ||
| "host": self.host.get_secret_value(), | ||
| "port": self.port, | ||
| "password": self.password.get_secret_value(), |
There was a problem hiding this comment.
Just double-check, removing "password" from connection info is as expected?
|
There are lint issues, please check them ~ pip install black ruff --upgrade
make format
make lint |
|
Do you guys need me to do anything else? Can we merge this change? |
|
@bjpietrzak Could you explain why it's necessary to remove the password and port? |
It's not. Will change it this evening. |
|
Sorry for the delay |
|
/assign @XuanYang-cn |
|
@bjpietrzak Plz fix the conflicts so that I can merge this PR, THX |
|
@XuanYang-cn fixed |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alwayslove2013, bjpietrzak, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Have I implemented the CLI erroniously? I can't see Chroma client in vectodbbench cmd. |
4 participants
Added Chroma client to VectorDBBench. Extended
chroma/config.pyfunctionalities to make them similar to the weaviatecloud client.