Update cli.py fix bug (#649)#651
Merged
alwayslove2013 merged 1 commit intozilliztech:mainfrom Nov 28, 2025
Merged
Conversation
Contributor
Author
|
/assign @alwayslove2013 |
alwayslove2013
approved these changes
Nov 27, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alwayslove2013, WSL0809 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/assign @XuanYang-cn |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
root cause: #649
how to fix:
The front-end UI periodically calls benchmark_runner.has_running() to refresh the progress bar. This incidentally consumes the SUCCESS signal, and the running_task will be properly cleaned up. Therefore, the front-end process is OK. So my fix fully reuses the existing public API: benchmark_runner.has_running(), which is consistent with the front-end usage.