keep old method signature for backwards compatibility#2
Merged
zinking merged 1 commit intozinking:rewrite_branchfrom Sep 2, 2024
amitgilad3:rewrite_branch
Merged
keep old method signature for backwards compatibility#2zinking merged 1 commit intozinking:rewrite_branchfrom amitgilad3:rewrite_branch
zinking merged 1 commit intozinking:rewrite_branchfrom
amitgilad3:rewrite_branch
Conversation
Author
|
Hey @zinking , i tried to make RewriteDataFilesCommitManager to be backwards compatible , please take a look and if its okay merge , tnx :) |
Owner
|
you'd probably open another PR under apache iceberg |
Author
|
if you prefer ill just open another pr so it wont bother you |
Owner
|
I'm fine either way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix backward compatibility for RewriteDataFilesCommitManager