Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BlakeMScurr
reviewed
Nov 22, 2022
Collaborator
BlakeMScurr
left a comment
BlakeMScurr
left a comment
There was a problem hiding this comment.
Partial review, I still have a lot to read!
| { | ||
| "indexed": true, | ||
| "internalType": "bool", | ||
| "name": "isVerifie", |
Collaborator
There was a problem hiding this comment.
I noticed you fixed this in the other pr. Is this out of date?
Contributor
Author
There was a problem hiding this comment.
We do need to update these files, but first, we should wait to see if we need to redeploy from:
zkMaps/zkMaps#43
zkMaps/zkMaps#44
packages/react-app/src/App.jsx
Outdated
| <Route exact path="/create"> | ||
| <CreateZone {...routeProps} /> | ||
| </Route> | ||
| <Route exact path="/ethdenver"> |
Collaborator
There was a problem hiding this comment.
What's /ethdenver for? Why does it just have the same stuff as Home?
Contributor
Author
There was a problem hiding this comment.
/ethdenver has the map we released for the hackathon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
⛑️ What was done:
🎫 Ticket:
Type of change
Please delete options that are not relevant.
🧪 How to test:
🗒️ Notes:
Closes #(issue)