Add paste.gentoo.zip #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxc3nsoredxx
suggested changes
Oct 14, 2023
Contributor
|
Looks ok otherwise. Personally, I'd also squash the commits. |
Contributor
Author
|
Cleaned it up! How's it look? |
xxc3nsoredxx
suggested changes
Oct 15, 2023
Contributor
|
You also clobbered the commit message when squashing. If you could make it something useful, that'd be nice. |
Contributor
Author
|
Would "Add new service - paste.gentoo.zip" suffice? |
Contributor
|
Sure. Maybe mention in the message body that you specify |
Specified in the code with `pgz` and in the cli for usage and brevity.
Contributor
Author
|
How's that look? |
Contributor
|
LGTM |
xxc3nsoredxx
added a commit
to xxc3nsoredxx/gentoo
that referenced
this pull request
Oct 15, 2023
From zlin/wgetpaste#48 Signed-off-by: Oskari Pirhonen <xxc3ncoredxx@gmail.com>
Collaborator
|
Thanks! |
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Oct 19, 2023
From zlin/wgetpaste#48 Signed-off-by: Oskari Pirhonen <xxc3ncoredxx@gmail.com> Closes: #33340 Signed-off-by: Florian Schmaus <flow@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made sure to run
test.shbefore submitting and all tests pass.