This is a dup of the official library

[Rich2k]

Please fork and pull request to https://github.com/Rich2k/adLDAP not releasing a separate library

[ztec]

This "dup" was the first reference of adLdap on github, and is used by many people. To avoid making all existing dev based on it, many things need to be done on the original (yours).

Even, if all modification won't be integrated, some must be.

• namespace
• Composer.json (for packagist)

The current packagist package is here : https://packagist.org/packages/adldap/adldap
Forks : https://github.com/ztec/adLDAP/network

[Rich2k]

You should add an upstream and contribute to the original library rather than split the code base into two incompatible libraries

[ztec]

yes, I know. I will make pull request. But this "copy" will be removed when both original and copy will be compatible.

I didn't make many modification. Only modification required for psr-2 based code.

[samwilson]

@Rich2k I hadn't realised that adLdap was on Github. Thanks for doing so. I assume the old bug tracker http://sourceforge.net/apps/trac/adldap/ is not to be used any more -- would it be possible to put a note on that site somehow? I had it bookmarked and hadn't been to the main adldap.sf.net site for a while, and was rather thinking that development had ground to a halt. :-( Glad that it hasn't!

Oh, and have you added it to https://packagist.org/ ? Because I can't find it there... :(

[ChadSikorra]

At a minimum, it would probably make sense to change the name in your composer file to something other than "adldap/adldap". Perhaps "ztec/adldap"? Case in point: I originally had a custom repository entry defined in my composer.json with the name defined as "adldap/adldap" and pointed to the .zip file to the official library on SourceForce. When you added your project to packagist it pulled in your fork instead of the zip file (since it has the name you would expect of the official library, adldap/adldap). It was pretty confusing to figure out what broke when that happened.

Unfortunately the name change will break things for people with your fork defined in their composer.json file, but it's something that should really be done.

[samwilson]

I think the only thing that will break will be the use of the namespace in this fork. At least, that's all I've had to change so far in switching back to the proper repo.

[ChadSikorra]

Yeah, that's what I meant. If the names get swapped (this repo uses a name like ztec/adldap) and Rich's repo takes over as the new adldap/adldap on packagist, then someone doing php composer.phar update would immediately have issues until they account for the namespace difference (assuming namespacing doesn't make it upstream in time).

However, more problematic is that you cannot actually delete or rename your package once it's entered into packagist: composer/packagist#115 At least not without contacting the maintainer of the site and asking them to delete it.

[ztec]

The name adldap/adldap will be released for the "real" official adldap repository.
But only when some steps will be done

• Official adldap must have a composer.json
• Official may use the namespace (but not required)
• my sf2 bundle that use adldap is fixed to work with the official lib

I will make the work & PR this week end.

[ztec]

I forgot :

• Some tag need to be added on the official repositories (for packagist versioning!)

[Rich2k]

• Has a composer.json
• Has namespacing

[ztec]

I just saw that a minute ago Good job. you are fast ;-)

[samwilson]

I'm glad to hear the Packagist name will be united with the correct repository. Thanks @ztec.

[ztec]

In order to have a clean reference and don't rely on the dev-master version, a tag need to be pushed on the official Repo'. Once it's done, package on packagist will be redirected.

[laurinkeithdavis]

Until then, can one of you add a release on Packagist for 4.0.4? I'm trying to switch my project to Packagist for this dependency, but I need the updates in 4.0.3 and 4.0.4.

[laurinkeithdavis]

Nevermind. This fork doesn't have the one change I need (ldapSlashes.) argh,