Node 10 nan api changes and zstd 1.3.4#2
Open
Stieneee wants to merge 2 commits intozwb-ict:masterfrom
Open
Conversation
change to nan realted calls to support node 10 fixed incorrect tests moved out buffers from worker removed destroy call as was causing seg fault
increase mocha timeout for slow ci performance
|
@zwb-ict Bump! |
|
sad |
|
If someone is looking for decompressing |
Author
|
@paambaati looks interesting thanks for the share. After this failed to merge I actually created a new package that uses the zstd binary. My belief is that spawning the second process is more resource-friendly than an in javascript implementation. The package should also be more resilient to Node version changes and easier to keep up-to-date with current zstd. Docs should probably be updated to use the pipeline method. I have been using simple-zstd for a while now in my applications and it has been reliable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the package.
Wanted an update to date implementation of zstd running in node 10. Some nan api definitions had deprecated resulting in failed compilation.
With some stress testing I was getting some seg faults. Stack traces lead me into nan. After moving the output buffer and removing the sync worker->Destroy() call everything is behaving correctly. I confirmed that the worker is still being destroyed properly after a sync call.
Some of the tests were missing some done calls.