-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Small Documentation Improvement #3786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
runtime/help/plugins.md
Outdated
| metadata) which it knows about. By default, micro only knows about the official | ||
| channel which is located at github.com/micro-editor/plugin-channel but you can | ||
| metadata) which it knows about. By default, micro only knows about the [official | ||
| channel](github.com/micro-editor/plugin-channel) but you can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https:// ?
runtime/help/plugins.md
Outdated
| ``` | ||
|
|
||
| Then open a pull request at github.com/micro-editor/plugin-channel, adding a | ||
| Then open a pull request at the [official plugin channel](github.com/micro-editor/plugin-channel), adding a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
runtime/help/plugins.md
Outdated
| To make updating the plugin work, the first line of your plugin's lua code | ||
| should contain the version of the plugin. (Like this: `VERSION = "1.0.0"`) | ||
| Please make sure to use [semver](http://semver.org/) for versioning. | ||
| Please make sure to use [semver](http://semver.org/) for versioning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't remove empty line at the end of file.
But while we're at this line, s/http/https/ would be a good idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/http/https/ would be a good idea?
I'd say it's a good idea. There are more http occurrences over the repo, perhaps we could change those as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps. Except for those in LICENSE-THIRD-PARTY, xml schemas in assets/*.svg and so on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, my bad. I should've checked explicitly, but I thought my browser would fall back to HTTPS if it was available.
57032ef to
ad9301f
Compare
No description provided.