Skip to content

Support for Blazor webassembly#360

Merged
StefH merged 2 commits intozzzprojects:masterfrom
julienGrd:master
Mar 24, 2020
Merged

Support for Blazor webassembly#360
StefH merged 2 commits intozzzprojects:masterfrom
julienGrd:master

Conversation

@julienGrd
Copy link
Contributor

#358

added linker config to make library work on mono project + added a webassembly blazor app with some dynamic order by

…bassembly blazor app whith some dynamic order by
@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #360 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   88.56%   88.56%           
=======================================
  Files          46       46           
  Lines        4531     4531           
=======================================
  Hits         4013     4013           
  Misses        518      518           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d5c560...4ee86cb. Read the comment docs.

@StefH StefH changed the title https://github.com/StefH/System.Linq.Dynamic.Core/issues/358 Support for Blazor webassembly Mar 24, 2020
Copy link
Collaborator

@StefH StefH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at my question

box-shadow: 0 -1px 2px rgba(0, 0, 0, 0.2);
display: none;
left: 0;
padding: 0.6rem 1.25rem 0.7rem 1.25rem;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small Codefactor issue, can you fix this?

image

Copy link
Collaborator

@StefH StefH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small issue in css, can you check?

correct codefactor issue
@julienGrd julienGrd requested a review from StefH March 24, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants