Skip to content

Remove all MSBuild files#141

Merged
majcosta merged 1 commit into
1dot13:masterfrom
majcosta:pr_remove_old_msbuild_files
May 8, 2023
Merged

Remove all MSBuild files#141
majcosta merged 1 commit into
1dot13:masterfrom
majcosta:pr_remove_old_msbuild_files

Conversation

@majcosta
Copy link
Copy Markdown
Contributor

@majcosta majcosta commented May 7, 2023

now that CI is using cmake, we can be clean up the tree quite a bit

btw, cmake can still configure for the msbuild generator for those so inclined:

create the folder, cmd to it, run cmake [project_root_dir] -G"Visual Studio 17 2022" -A Win32 -DLanguages=ENGLISH -DApplications=JA2 once, then open the solution file using Visual Studio 2022

now that CI is using cmake, we can be clean up the tree quite a bit

btw, cmake can still configure for the msbuild generator for those so inclined:

create the folder, cmd to it, run `cmake [project_root_dir] -G"Visual Studio 17 2022" -A Win32 -DLanguages=ENGLISH -DApplications=JA2` once, then open the solution file using Visual Studio 2022
@NorthFury
Copy link
Copy Markdown
Contributor

Can we add a section to the readme file for how to work on the project? This can include the line you added in the description.
Without the visual studio solution files, it would have taken too much effort for me to open the project in an IDE and get it to build. It would make the entry barrier for future contributors too high.
What IDE are you using?

@majcosta
Copy link
Copy Markdown
Contributor Author

majcosta commented May 8, 2023

My next PR is exactly that. I'm using Visual Studio 2022.

@majcosta majcosta merged commit 760f8ab into 1dot13:master May 8, 2023
@majcosta majcosta deleted the pr_remove_old_msbuild_files branch May 8, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants