make gitignore Visual Studio definitions more specific#144
Merged
Conversation
majcosta
requested changes
May 18, 2023
Comment on lines
+8
to
+9
| /lib/ | ||
| /out/ |
Contributor
There was a problem hiding this comment.
after #141 these two aren't necessary anymore, you can remove
Contributor
Author
There was a problem hiding this comment.
With the import procedure for Visual Studio 2022, the CMakeSettings.json file is generated, together with a /out/ directory. I think we should keep the /out/ line for now.
| @@ -3,9 +3,9 @@ | |||
| cmake-build-*/ | |||
Contributor
There was a problem hiding this comment.
you can prepend a / to these too
Contributor
There was a problem hiding this comment.
GitHub isn't being helpful, but I meant to include the .idea line in that as well
majcosta
approved these changes
May 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change has gitignore only ignore files from the repo root directory.