Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Refactor: AddressInfo and EtherscanButton#50

Merged
nicosampler merged 9 commits intodevelopmentfrom
address-info-refactor
Aug 5, 2020
Merged

Refactor: AddressInfo and EtherscanButton#50
nicosampler merged 9 commits intodevelopmentfrom
address-info-refactor

Conversation

@nicosampler
Copy link
Contributor

@nicosampler nicosampler commented Aug 4, 2020 •
edited
Loading

  • Remove type in EtherscanButton. It can be inferred using value length. If it's > 42 is assumed to be a TX else an address. If the value is > (66 a TX) can be assumed to be a data value, but for this case, EtherscaButton should not be used.

  • Rename AddressInfo to EthHashInfo and make the required changes to work with the new EthersacanButton interface.

  • @fernandomg requested to stop events propagation for EtherscanButton and copyButton. That's to avoid problems with <AddressInput /> component.

@nicosampler nicosampler requested review from fernandomg and mmv08 August 4, 2020 17:54
@nicosampler nicosampler self-assigned this Aug 4, 2020
@github-actions
Copy link

github-actions bot commented Aug 4, 2020 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Aug 4, 2020

Travis automatic deployment:
https://pr50--safereactcomponents.review.gnosisdev.com

@ghost
Copy link

ghost commented Aug 4, 2020

Travis automatic deployment:
https://pr50--safereactcomponents.review.gnosisdev.com

@nicosampler nicosampler mentioned this pull request Aug 4, 2020
Merged
fernandomg
fernandomg suggested changes Aug 4, 2020
View reviewed changes
mmv08
mmv08 reviewed Aug 5, 2020
View reviewed changes
@ghost
Copy link

ghost commented Aug 5, 2020

Travis automatic deployment:
https://pr50--safereactcomponents.review.gnosisdev.com

fernandomg
fernandomg reviewed Aug 5, 2020
View reviewed changes
fernandomg
fernandomg reviewed Aug 5, 2020
View reviewed changes
fernandomg
fernandomg reviewed Aug 5, 2020
View reviewed changes
fernandomg
fernandomg reviewed Aug 5, 2020
View reviewed changes
fernandomg
fernandomg reviewed Aug 5, 2020
View reviewed changes
fernandomg
fernandomg reviewed Aug 5, 2020
View reviewed changes
Copy link
Contributor

@fernandomg fernandomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicosampler left a few comments

@nicosampler
Copy link
Contributor Author

nicosampler commented Aug 5, 2020

sorry, it was too early. Check it now @fernandomg, please.

@ghost
Copy link

ghost commented Aug 5, 2020

Travis automatic deployment:
https://pr50--safereactcomponents.review.gnosisdev.com

@ghost
Copy link

ghost commented Aug 5, 2020

Travis automatic deployment:
https://pr50--safereactcomponents.review.gnosisdev.com

fernandomg
fernandomg reviewed Aug 5, 2020
View reviewed changes
fernandomg
fernandomg reviewed Aug 5, 2020
View reviewed changes
fernandomg
fernandomg reviewed Aug 5, 2020
View reviewed changes
nicosampler and others added 3 commits August 5, 2020 10:47
@nicosampler @fernandomg
Update src/ethereum/EtherscanButton/index.tsx
8ecccf5 
replace onKyePress by onKeyDown

Co-authored-by: Fernando <fernando.greco@gmail.com>
@nicosampler @fernandomg
Update src/utils/CopyToClipboardBtn/index.tsx
592626f 
replace onKyePress by onKeyDown

Co-authored-by: Fernando <fernando.greco@gmail.com>
@nicosampler
remove event existence check
29a77d9
@ghost
Copy link

ghost commented Aug 5, 2020

Travis automatic deployment:
https://pr50--safereactcomponents.review.gnosisdev.com

@fernandomg fernandomg self-requested a review August 5, 2020 13:58
@ghost
Copy link

ghost commented Aug 5, 2020

Travis automatic deployment:
https://pr50--safereactcomponents.review.gnosisdev.com

@nicosampler
Copy link
Contributor Author

nicosampler commented Aug 5, 2020

@mikheevm I'm merging this PR so we can move forward. If you think any other change needs to be done, I'll work on it in a new PR.

@nicosampler nicosampler merged commit 45c746a into development Aug 5, 2020
@nicosampler nicosampler deleted the address-info-refactor branch August 5, 2020 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@mmv08 mmv08 mmv08 left review comments

@fernandomg fernandomg fernandomg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nicosampler nicosampler

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicosampler @fernandomg @mmv08